Oel 462: facet list template overriden. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
requested changes
Sep 15, 2021
| */ | ||
| protected function setUp(): void { | ||
| parent::setUp(); | ||
| /** @var \Drupal\Core\Extension\ThemeInstallerInterface $theme_installer */ |
There was a problem hiding this comment.
Tests were excluded from this task as agreed.
| * @covers ::getFacets | ||
| * @covers ::removeFacet | ||
| */ | ||
| public function testFacets() { |
There was a problem hiding this comment.
Suggested change
| public function testFacets() { | |
| public function testFacetsRendering(): void { |
There was a problem hiding this comment.
Tests were excluded from this task as agreed.
|
|
||
| $facets = ['foo' => 'bar']; | ||
| $entity->setFacets($facets); | ||
| $this->assertEquals($facets, $entity->getFacets()); |
There was a problem hiding this comment.
we need to render the build of the facets summary block, and assert the markup with Crawler
There was a problem hiding this comment.
Tests were excluded from this task as agreed.
drishu
requested changes
Sep 15, 2021
| {%- if items -%} | ||
| {%- for item in items -%} | ||
| {% if item.value['#type'] == 'link' %} | ||
| {% include '@oe-bcl/bcl-badge/badge.html.twig' with { |
There was a problem hiding this comment.
{{ pattern('badge', {
'label': 'label',
'assistive_text': 'assistive_text',
'url': '#',
'icons_path': bcl_icon_path,
'dismissible': true
}) }}
…ade according to the feedback.
Maxfire
changed the title
GilNovacomm
approved these changes
Sep 15, 2021
drishu
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.